Sun, 17 Dec 2023 15:33:50 +0100
fix faulty string to int conversion utilities
Probably it was expected that errno is set to EINVAL when illegal characters are encountered. But this is not standard and does not happen on every system, allowing illegal strings to be parsed as valid integers.
/* * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER. * * Copyright 2018 Olaf Wintermann. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE * POSSIBILITY OF SUCH DAMAGE. */ #ifndef METHODS_H #define METHODS_H #include "webdav.h" #include "resource.h" #include <cx/list.h> #ifdef __cplusplus extern "C" { #endif typedef struct PropfindParser PropfindParser; typedef struct ResponseTag ResponseTag; typedef struct LockDiscovery LockDiscovery; struct PropfindParser { xmlDoc *document; xmlNode *current; }; struct ResponseTag { const char *href; int iscollection; CxList *properties; const char *crypto_name; const char *crypto_key; }; struct LockDiscovery { char *timeout; char *locktoken; }; int dav_buffer_seek(CxBuffer *b, curl_off_t offset, int origin); CURLcode do_propfind_request( DavSession *sn, CxBuffer *request, CxBuffer *response); CURLcode do_proppatch_request( DavSession *sn, char *lock, CxBuffer *request, CxBuffer *response); CURLcode do_put_request( DavSession *sn, char *lock, DavBool create, void *data, dav_read_func read_func, dav_seek_func seek_func, size_t length); CxBuffer* create_allprop_propfind_request(void); CxBuffer* create_cryptoprop_propfind_request(void); CxBuffer* create_propfind_request(DavSession *sn, CxList *properties, char *rootelm, DavBool nocrypt); CxBuffer* create_basic_propfind_request(void); PropfindParser* create_propfind_parser(CxBuffer *response, char *url); void destroy_propfind_parser(PropfindParser *parser); int get_propfind_response(PropfindParser *parser, ResponseTag *result); void cleanup_response(ResponseTag *result); int hrefeq(DavSession *sn, const char *href1, const char *href2); DavResource* response2resource(DavSession *sn, ResponseTag *response, char *parent_path); void add_properties(DavResource *res, ResponseTag *response); DavResource* parse_propfind_response(DavSession *sn, DavResource *root, CxBuffer *response); int parse_response_tag(DavResource *resource, xmlNode *node); void set_davprops(DavResource *res); /* * parses the content of a resourcetype element * returns 1 if the resourcetype is a collection, 0 otherwise */ int parse_resource_type(xmlNode *node); CxBuffer* create_proppatch_request(DavResourceData *data); CxBuffer* create_crypto_proppatch_request(DavSession *sn, DavKey *key, const char *name, const char *hash); CURLcode do_delete_request(DavSession *sn, char *lock, CxBuffer *response); CURLcode do_mkcol_request(DavSession *sn, char *lock); CURLcode do_head_request(DavSession *sn); CURLcode do_copy_move_request(DavSession *sn, char *dest, char *lock, DavBool copy, DavBool override); CxBuffer* create_lock_request(void); int parse_lock_response(DavSession *sn, CxBuffer *response, LockDiscovery *lock); CURLcode do_lock_request(DavSession *sn, CxBuffer *request, CxBuffer *response, time_t timeout); CURLcode do_unlock_request(DavSession *sn, char *locktoken); CURLcode do_simple_request(DavSession *sn, char *method, char *locktoken); CURLcode do_report_request(DavSession *sn, CxBuffer *request, CxBuffer *response); #ifdef __cplusplus } #endif #endif /* METHODS_H */