make dav_copy/move newpath arg const dav-2 tip

Thu, 02 Jul 2026 20:50:47 +0200

author
Olaf Wintermann <olaf.wintermann@gmail.com>
date
Thu, 02 Jul 2026 20:50:47 +0200
branch
dav-2
changeset 921
3ffee649f0b1
parent 920
92fcd6a8cf9e

make dav_copy/move newpath arg const

libidav/methods.c file | annotate | diff | comparison | revisions
libidav/methods.h file | annotate | diff | comparison | revisions
libidav/resource.c file | annotate | diff | comparison | revisions
libidav/webdav.h file | annotate | diff | comparison | revisions
--- a/libidav/methods.c	Wed Jul 01 21:09:22 2026 +0200
+++ b/libidav/methods.c	Thu Jul 02 20:50:47 2026 +0200
@@ -1057,7 +1057,7 @@
 }
 
 
-CURLcode do_copy_move_request(DavSession *sn, char *dest, char *lock, DavBool copy, DavBool override) { 
+CURLcode do_copy_move_request(DavSession *sn, const char *dest, const char *lock, DavBool copy, DavBool override) { 
     CURL *handle = sn->handle;
     if(copy) {
         curl_easy_setopt(handle, CURLOPT_CUSTOMREQUEST, "COPY");
@@ -1233,7 +1233,7 @@
     return ret;
 }
 
-CURLcode do_simple_request(DavSession *sn, char *method, char *locktoken) {
+CURLcode do_simple_request(DavSession *sn, const char *method, char *locktoken) {
     CURL *handle = sn->handle;
     curl_easy_setopt(handle, CURLOPT_CUSTOMREQUEST, method);
     curl_easy_setopt(handle, CURLOPT_UPLOAD, 0L);
--- a/libidav/methods.h	Wed Jul 01 21:09:22 2026 +0200
+++ b/libidav/methods.h	Thu Jul 02 20:50:47 2026 +0200
@@ -115,14 +115,14 @@
 
 CURLcode do_head_request(DavSession *sn);
 
-CURLcode do_copy_move_request(DavSession *sn, char *dest, char *lock, DavBool copy, DavBool override);
+CURLcode do_copy_move_request(DavSession *sn, const char *dest, const char *lock, DavBool copy, DavBool override);
 
 CxBuffer* create_lock_request(void);
 int parse_lock_response(DavSession *sn, CxBuffer *response, LockDiscovery *lock);
 CURLcode do_lock_request(DavSession *sn, CxBuffer *request, CxBuffer *response, time_t timeout);
 CURLcode do_unlock_request(DavSession *sn, char *locktoken);
 
-CURLcode do_simple_request(DavSession *sn, char *method, char *locktoken);
+CURLcode do_simple_request(DavSession *sn, const char *method, char *locktoken);
 
 CURLcode do_report_request(DavSession *sn, CxBuffer *request, CxBuffer *response);
 
--- a/libidav/resource.c	Wed Jul 01 21:09:22 2026 +0200
+++ b/libidav/resource.c	Thu Jul 02 20:50:47 2026 +0200
@@ -1179,7 +1179,7 @@
     }
 }
 
-DavResource* dav_create_child(DavResource *parent, char *name) {
+DavResource* dav_create_child(DavResource *parent, const char *name) {
     DavResource *res = dav_resource_new_child(parent->session, parent, name);
     if(dav_create(res)) {
         dav_resource_free(res);
@@ -1335,7 +1335,7 @@
     }
 }
 
-static int dav_cp_mv_url(DavResource *res, char *desturl, _Bool copy, _Bool override) {
+static int dav_cp_mv_url(DavResource *res, const char *desturl, _Bool copy, _Bool override) {
     DavSession *sn = res->session;
     CURL *handle = sn->handle;
     util_set_url(sn, dav_resource_get_href(res));
@@ -1355,7 +1355,7 @@
     }
 }
 
-static int dav_cp_mv(DavResource *res, char *newpath, _Bool copy, _Bool override) {
+static int dav_cp_mv(DavResource *res, const char *newpath, _Bool copy, _Bool override) {
     char *dest = dav_session_get_href(res->session, newpath);
     char *desturl = util_get_url(res->session, dest);
     dav_session_free(res->session, dest);
@@ -1365,27 +1365,27 @@
     return ret;
 }
 
-int dav_copy(DavResource *res, char *newpath) {
+int dav_copy(DavResource *res, const char *newpath) {
     return dav_cp_mv(res, newpath, true, false);
 }
 
-int dav_move(DavResource *res, char *newpath) {
+int dav_move(DavResource *res, const char *newpath) {
     return dav_cp_mv(res, newpath, false, false);
 }
 
-int dav_copy_o(DavResource *res, char *newpath, DavBool override) {
+int dav_copy_o(DavResource *res, const char *newpath, DavBool override) {
     return dav_cp_mv(res, newpath, true, override);
 }
 
-int dav_move_o(DavResource *res, char *newpath, DavBool override) {
+int dav_move_o(DavResource *res, const char *newpath, DavBool override) {
     return dav_cp_mv(res, newpath, false, override);
 }
 
-int dav_copyto(DavResource *res, char *url, DavBool override) {
+int dav_copyto(DavResource *res, const char *url, DavBool override) {
     return dav_cp_mv_url(res, url, true, override);
 }
 
-int dav_moveto(DavResource *res, char *url, DavBool override) {
+int dav_moveto(DavResource *res, const char *url, DavBool override) {
     return dav_cp_mv_url(res, url, false, override);
 }
 
--- a/libidav/webdav.h	Wed Jul 01 21:09:22 2026 +0200
+++ b/libidav/webdav.h	Thu Jul 02 20:50:47 2026 +0200
@@ -348,17 +348,17 @@
 
 char* dav_resource_get_href(DavResource *resource);
 
-DavResource* dav_create_child(DavResource *parent, char *name);
+DavResource* dav_create_child(DavResource *parent, const char *name);
 int dav_delete(DavResource *res);
 int dav_create(DavResource *res);
 int dav_exists(DavResource *res);
 
-int dav_copy(DavResource *res, char *newpath);
-int dav_move(DavResource *res, char *newpath);
-int dav_copy_o(DavResource *res, char *newpath, DavBool override);
-int dav_move_o(DavResource *res, char *newpath, DavBool override);
-int dav_copyto(DavResource *res, char *url, DavBool override);
-int dav_moveto(DavResource *res, char *url, DavBool override);
+int dav_copy(DavResource *res, const char *newpath);
+int dav_move(DavResource *res, const char *newpath);
+int dav_copy_o(DavResource *res, const char *newpath, DavBool override);
+int dav_move_o(DavResource *res, const char *newpath, DavBool override);
+int dav_copyto(DavResource *res, const char *url, DavBool override);
+int dav_moveto(DavResource *res, const char *url, DavBool override);
 
 int dav_lock(DavResource *res);
 int dav_lock_t(DavResource *res, time_t timeout);

mercurial