make some session function args const dav-2 tip

Sun, 05 Jul 2026 20:08:44 +0200

author
Olaf Wintermann <olaf.wintermann@gmail.com>
date
Sun, 05 Jul 2026 20:08:44 +0200
branch
dav-2
changeset 922
42ecf0e5075a
parent 921
3ffee649f0b1

make some session function args const

libidav/session.c file | annotate | diff | comparison | revisions
libidav/webdav.c file | annotate | diff | comparison | revisions
libidav/webdav.h file | annotate | diff | comparison | revisions
--- a/libidav/session.c	Thu Jul 02 20:50:47 2026 +0200
+++ b/libidav/session.c	Sun Jul 05 20:08:44 2026 +0200
@@ -40,7 +40,7 @@
 #include "methods.h"
 #include "atomic.h"
 
-DavSession* dav_session_new(DavContext *context, char *base_url) {
+DavSession* dav_session_new(DavContext *context, const char *base_url) {
     if(!base_url) {
         return NULL;
     }
@@ -105,9 +105,9 @@
 
 DavSession* dav_session_new_auth(
         DavContext *context,
-        char *base_url,
-        char *user,
-        char *password)
+        const char *base_url,
+        const char *user,
+        const char *password)
 {
     DavSession *sn = dav_session_new(context, base_url);
     if(!sn) {
@@ -171,11 +171,9 @@
     }
 }
 
-void dav_session_set_baseurl(DavSession *sn, char *base_url) {
+void dav_session_set_baseurl(DavSession *sn, const char *base_url) {
     const CxAllocator *a = sn->mp->allocator;
-    if(sn->base_url) {
-        cxFree(a, sn->base_url);
-    }
+    cxFree(a, sn->base_url);
     
     cxstring url = cx_str(base_url);
     if(url.ptr[url.length - 1] == '/') {
--- a/libidav/webdav.c	Thu Jul 02 20:50:47 2026 +0200
+++ b/libidav/webdav.c	Sun Jul 05 20:08:44 2026 +0200
@@ -342,7 +342,7 @@
                 ctx,
                 cx_strn(prefixed_name, pname-prefixed_name));
         if(ns) {
-            *name = pname +1;
+            *name = pname + 1;
             return ns;
         } else {
             *name = NULL;
@@ -494,7 +494,7 @@
     return proplist;
 }
 
-DavResource* dav_query(DavSession *sn, char *query, ...) {
+DavResource* dav_query(DavSession *sn, const char *query, ...) {
     DavQLStatement *stmt = dav_parse_statement(cx_str(query));
     if(!stmt) {
         sn->error = DAV_ERROR;
--- a/libidav/webdav.h	Thu Jul 02 20:50:47 2026 +0200
+++ b/libidav/webdav.h	Sun Jul 05 20:08:44 2026 +0200
@@ -288,18 +288,18 @@
 int dav_context_add_session(DavContext *context, DavSession *sn);
 int dav_context_remove_session(DavContext *context, DavSession *sn);
 
-DavSession* dav_session_new(DavContext *context, char *base_url);
+DavSession* dav_session_new(DavContext *context, const char *base_url);
 DavSession* dav_session_new_auth(
         DavContext *context,
-        char *base_url,
-        char *user,
-        char *password);
+        const char *base_url,
+        const char *user,
+        const char *password);
 DavSession* dav_session_clone(DavSession *sn);
 void dav_session_ref(DavSession *sn);
 void dav_session_unref(DavSession *sn);
 void dav_session_set_auth(DavSession *sn, const char *user, const char *password);
 void dav_session_set_auth_s(DavSession *sn, cxstring user, cxstring password);
-void dav_session_set_baseurl(DavSession *sn, char *base_url);
+void dav_session_set_baseurl(DavSession *sn, const char *base_url);
 void dav_session_enable_encryption(DavSession *sn, DavKey *key, int flags);
 
 void dav_session_set_authcallback(DavSession *sn, dav_auth_func func, void *userdata);
@@ -324,7 +324,7 @@
 
 CxList* parse_properties_string(DavContext *context, cxstring str);
 
-DavResource* dav_query(DavSession *sn, char *query, ...);
+DavResource* dav_query(DavSession *sn, const char *query, ...);
 
 cxmutstr dav_property_key(const char *ns, const char *name);
 void dav_get_property_namespace_str(

mercurial